Skip to content

update to visualization API 5.0.0#138

Merged
AlwinEsch merged 9 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change-api
May 25, 2026
Merged

update to visualization API 5.0.0#138
AlwinEsch merged 9 commits into
xbmc:Piersfrom
AlwinEsch:Piers-change-api

Conversation

@AlwinEsch

Copy link
Copy Markdown
Member

Add-on update related to Kodi API change defined on xbmc/xbmc#28278

Further done some few cleanups

Runtime tests on Windows and Linux are OK.

Taken few parts from #137 including the presets in add-on to have prepared for projectM v4.x.

The other rquest becomes rebased after this is in.

@AlwinEsch AlwinEsch requested a review from garbear May 20, 2026 12:17
@kodiai

kodiai Bot commented May 20, 2026

Copy link
Copy Markdown

Decision: APPROVE

kodiai response

Decision: APPROVE
Issues: none

Evidence:

  • Review prompt covered 50 changed files.
  • Review scope note: output was scoped by prompt budget limits; Review Details include bounded counts only.
Review Details
  • Review plan: ready hash=83ab2331acbc route=standard task=review.full files=4266 lines=841081(local-diff) budget=75t/1230s gates=3/3 publish=canonical-visible-surface graph=skipped candidates=preferred doctrine=disabled/0/0/0 reasons=disabl…

  • Review reducer: ready input=3 kept=3 suppressed=0 rewritten=0 deprioritized=0 lowConfidence=0 auditEvents=1 severityDemoted=0 graphValidated=0 graphUncertain=0 doctrine=disabled/0/0/0 reasons=disabled

  • Review candidates: shadow recorded=3 rejected=0 errors=0 artifact=present repo=xbmc-visualization.projectm pr=138 key=kodiai-review-output:v1:inst-109141824:xbmc-visualization.projectm:pr-138:action delivery=d937b7a0-5445-11f1-894f-3f1fb0a2f691

  • Review candidate publication: mode=blocked approved=3 rewritten=0 published=0 directFallback=0 reasons=none

  • Files reviewed: 4266

  • Findings: 0 critical, 0 major, 0 medium, 0 minor

  • Lines changed: +840996 -85

  • Requested profile: minimal (auto, lines changed: 841081)

  • Effective profile: minimal

  • Bounded review: covered 50/4266 changed files via large-PR triage (30 full, 20 abbreviated; 4216 not reviewed)

  • Timeout auto-reduction: applied

  • Contributor experience: profile-backed (using linked contributor profile guidance)

  • Shadow specialist: lane=docs-config-truth status=skipped reason=no-candidates candidateCount=0 decisionCount=0 decisionCounts=candidate:0,duplicate:0,disagreement:0,dismissed:0,unclassifiable:0 duplicateCount=0 disagreementCount=0 dismissedCount=0 unclassifiableCount=0 truncatedCandidateCount=0 metricAvailability=token:n,cost:n,latency:n visiblePublicationDenied=true approvalPublicationDenied=true privateOnly=true shadowOnly=true redacted=raw:n,publication:n,approval:n,unsafe:0 correlationKey=d47960a175934424 deliveryId=d937b7a0-5445-11f1-894f-3f1fb0a… reviewOutputKey=kodiai-review-output:v1:inst-10…

  • M072 candidate publication bridge: status=denied; bridgeVersion=candidate-publication-bridge.v1; bridgeId=candidate-publication-record:f2c7efbe860efdb358020f88d454848a; recordKey=candidate-publication-record:f2c7efbe860efdb358020f88d454848a; correlationKey=candidate-publication-bridge:62d5af91af1fcbb75a7b8f56ab9d36dc; source=review-handler-publication; candidateRef=candidate-publication-summary-3424551b; verification=none; counts=candidateCount:0,evidenceCount:0,verifiedCount:0,partiallyVerifiedCount:0,unverifiedCount:0,disprovenCount:0,publicationEligibleCount:0,malformedRecordCount:0,unsafeInputFieldCount:0; reasons=no-evidence,publication-ineligible; malformed=none; presence=deliveryId:y,reviewOutputKey:y,upstreamCorrelationKey:y,policyCorrelationKey:y; handoffOwner=available; redaction=privateOnly:y,rawPayloads:n,publicationFields:n,evidencePayloads:n,githubCommentBody:n,reducerRawPayload:n,discardedRawPayload:n,discardedPublicationFields:n,discardedEvidencePayloads:n

  • Review finding lifecycle: status=normalized; counts=input:3,recorded:3,rejected:0,unsafeInputFields:0; correlation=repo:y,pull:y,reviewOutputKey:y,deliveryId:y,commit:y; statuses=detected:3,open:3,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0; severity=critical:1,major:2,medium:0,minor:0; actionability=actionable:0,needs-human-review:3,needs-reproduction:0,blocked:0,not-actionable:0; reasons=automatic-detected,automatic-open,automatic-review; rejected=none; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Review validation truth: status=normalized; counts=detected:3,suggested:0,validated:0,revalidated:0,resolved:0,blocked:0,degraded:0,open:3,uncertain:0,inputFindings:3,unsafeInputFields:0; evidence=fresh:0,stale:0,missingValidation:3,missingRevalidation:3; reasons=validation-missing:3; refs=rfl-ec924fb360d0b0b2:open:validation-missing:fix:n:validation:n:revalidation:n,rfl-612863c3276ca155:open:validation-missing:fix:n:validation:n:revalidation:n,rfl-a6900b3bed28c6bd:open:validation-missing:fix:n:validation:n:revalidation:n; correlation=reviewOutputKey:y,deliveryId:y; redaction=privateOnly:y,rawPrompts:n,rawModelOutput:n,candidateBodies:n,replacementText:n,toolPayloads:n,secretLike:n,diffs:n,unboundedArrays:n,unsafeFields:0

  • Review completed: 2026-05-20T12:23:17.176Z

  • Total wall-clock: 5m 55s

  • Phase timings:

    • queue wait: 0ms
    • workspace preparation: 2.3s
    • retrieval/context assembly: 7.9s
    • executor handoff: 2m 13s
    • remote runtime: 3m 26s
    • publication: 3.1s
  • Tokens: 126 in / 6,644 out | 0.3573

  • Review scope: Reviewed 50/4266 files, prioritized by risk

  • Full review: 30 files | Abbreviated review: 20 files | Not reviewed: 4216 files

Files not fully reviewed (sorted by risk score)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_200/shifter - mandala.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/86.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/EoS + Phat - chasers 11 sentinel C_poltergeist_mix response daemon.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix07 recursive demons.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/Fumbling_Foo & Flexi, Martin, Orb, Unchained - Harmony Nova v2a.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/LuxXx - Makes Me Cry (five) (Makes Me Cry, So Lick My Tears, And Get Real High).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/Tripgnosis - Antimatter Streams.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_mischa_collection/raron, martin + flexi - squatting.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_projectM/Mstress & Juppy - Dancers In The Dark.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/EoS + Phat - chasers 18 hallway.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix02b.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix07 recursive demons.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/EoS - repeater 05 - rave on acid.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/EoS - repeater 15 - kaleidoscope b.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_stock/Mstress & Juppy - Dancers In The Dark.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/86.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/AdamFX 2 Geiss - Mash-Up - Angelic Staine Glass Chapters 6.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/AdamFX 2 Geiss - Mash-Up - Angelic Staine Glass Chapters 6_1.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/AdamFX 2 Geiss - Mash-Up Sphere Xibit Graffiti Warp me Tydye7.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/An AdamFX n Martin Infusion 2 flexi - Why The Sky Looks Diffrent Today - AdamFx n Martin Infusion - Tack Tile Disfunction B.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Bdrv EoS + Redi Jedi - frequency analysis + glowsticks - glow - o - scope male left handed complement BDRV et AL rmx2.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EOE125~1.MILk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + Phat - chasers 11 sentinel C_poltergeist_mix response daemon.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + Phat - chasers 12 sentinel Daemon - mash0000 - multi-band time-distortion aurora granules.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + Phat - chasers 14 sentinel 616.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + Phat - chasers 18 hallway.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + Phat - chasers 19 Portal.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + flexi - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix02b + illumination (Stahl's Mix).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS + phat - chasers 11 sentinel c (jelly v4.x).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - glowsticks v2 03 music shifter edit b (Jelly V2).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - glowsticks v2 03 music shifter edit b (Stahl's Reactive RMX V2i2 - feat. flexi + phat).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix02b.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix03 madhatter_v2.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - glowsticks v2 05 and proton lights (+Krash's beat code) _Phat_remix07 recursive demons.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - repeater 05 - rave on acid.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/EoS - repeater 15 - kaleidoscope b.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Flexi - 100% shader fractal [origami edit].milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Flexi - intensive shader fractal [suksma comp shader mix].milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Flexi - intensive shader fractal.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Flexi - mindblob [where it's at now] gno sth air fetch.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Flexi - supersonic.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/LuX - Life's Game 1.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/LuxXx - Makes Me Cry (five) (Makes Me Cry, So Lick My Tears, And Get Real High).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/LuxXx - StickVerse II.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/LuxXx - Stickflower II.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Mstress & Juppy - Dancers In The Dark.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/ORB - Depth Charge 2.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Stahlregen & EoS + Geiss + ORB + Phat - Fruitsticks (Flexi-Tex Shader).milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Tripgnosis - Antimatter Streams.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/Tripgnosis - Negative Photon Burn.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/_Mig_085.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/beta106S + Phat - sentinel linearity b nz+ mbinistre ov mbajiq.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/ech0 - liquid firesticks I.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/flexi + cope - i blew you a soap bubble now what - feel the projection you are, connected to it all nz+ wrepwrimindloss w8.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/flexi + geiss - infused with the spiral (Heavy Oil Mix) nz+ rapery.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/flexi - lorenz chaser [accidental shader-lock mashup] (ripples)2 nz+ discombobule lose.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/martin - fresco flash - cainlien.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/schglasmia - danqueer.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_tryptonaut/suksma - flexi - lorenz chaser - heretical tribal necklace.milk (risk: 55)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS + Geiss - glowsticks v2 03 music shifter edit b (water mix).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS + Phat - cubetrace - v2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS - glowsticks v2 03 music shifter edit b.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS - glowsticks v2 03 music.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS - glowsticks v2 04 music minimal.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/EoS and PieturP - AlienSpaceshipInvasion 2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/Flexi - smashing fractals 2-0.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/ORB - Supernova Meltdown.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/shifter - cellular_Phat_YAK_Infusion_v2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/yin - 290 - Sonic brainstorm.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/yin - 300 - Daydreamer.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/yin - 302 - Daydreamer (remix 2).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_bltc201/yin - 317 - Ocean of Light (y remix).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_eyetune/Martin N AdamFX Infusion = Phat+Yin+EoS_Mandala Chaser Ft AdamFX n Martin - The Beast Mandala Chaser FX H.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_eyetune/New Creation Sensation - AdamFx,Flexi,Amandio c n Martin - Star to Another World ft Hexocollie n Shadow Harlequin n Geiss B.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_eyetune/ORB - Mega Spectrum.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_eyetune/ORB - Nova Sunrise.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/A.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS + Phat - chasers 08 nematode_Teal_mix.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS + Phat - cubetrace - v2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS - glowsticks v2 03 music.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS - glowsticks v2 04 music minimal.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS 3d-glasses.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/EoS_Phat Whale_soul-monitor danger - music.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/Redi Jedi - triptacular to the max(maxtacular to the trip remix).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/Studio Music - Intuitive Awareness (Traces of Love mix).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/Studio Music - Intuitive Awareness (stimulus effect mix) .milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/Studio Music and Redi Jedi - Passionate Behavior.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/Studio Music and Redi Jedi - Shimmering Love (remix).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - cellular_Phat_Spinny_Slide_mix_v2_Time_Mod_tan.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - cellular_Phat_Spinny_Swimmer_mix_v2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - cellular_Phat_YAK_Infusion_v2.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - deep sea hydra spectrum.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - fuzzball.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/shifter - glassworms flare.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin + Phat + EoS - Dreams of Blood.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin - 280 - Coming home.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin - 290 - Sonic brainstorm.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin - 300 - Daydreamer.milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin - 302 - Daydreamer (remix 2).milk (risk: 54)
  • visualization.projectm/resources/projectM/presets/presets_milkdrop_104/yin - 317 - Ocean of Light (y remix).milk (risk: 54)
  • ...and 4116 more files
- Keyword parsing: No keywords detected - Budget behavior: scoped (prompt-budget-limited). - Prompt budget: 5 sections, 3 trimmed, 0 bypassed, 2213 trimmed tokens. - Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed. - Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.
  • Keyword parsing: No keywords detected
  • Budget behavior: scoped (prompt-budget-limited).
  • Prompt budget: 5 sections, 3 trimmed, 0 bypassed, 2213 trimmed tokens.
  • Cache behavior: 2 observations, 1 hits, 1 misses, 0 degraded, 0 bypassed.
  • Continuation behavior: 0 observations, 0 compacted, 0 fallback, 0 degraded, 0 bypassed.

@AlwinEsch AlwinEsch changed the title update to visualization API 4.1.0 update to visualization API 5.0.0 May 22, 2026
AlwinEsch added 9 commits May 24, 2026 08:54
Is to hold the code on longer lines a bit more clean and prevent wrong spaces or tabs.
This code was from the time as add-on was included in Kodi itself and with older ProjectM versions.
Value call "g_presets[preset]" no more possible as "g_presets" no more present.
As on ProjectM Version 4 no more presets are present do we need to include into add-on.
See also the note here: https://github.com/projectM-visualizer/projectm/blob/master/README.md#presets
Relates to:
```
  CMake Deprecation Warning at CMakeLists.txt:2 (cmake_policy):
    Compatibility with CMake < 3.10 will be removed from a future version of
    CMake.
```

And to have equal to Kodi's used version.
@AlwinEsch AlwinEsch merged commit 054d47e into xbmc:Piers May 25, 2026
8 checks passed
@AlwinEsch AlwinEsch deleted the Piers-change-api branch May 25, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant